Skip to content

Conversation

@damyanpetev
Copy link
Member

Ran generation on JSON Schema files and removed obsolete one for theme props (theme changes in use).

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Lipata
Lipata previously approved these changes Sep 24, 2025
@ChronosSF ChronosSF changed the base branch from master to 20.1.x September 25, 2025 14:19
@ChronosSF ChronosSF dismissed Lipata’s stale review September 25, 2025 14:19

The base branch was changed.

@github-actions
Copy link

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Nov 25, 2025
@Lipata Lipata requested a review from Copilot November 25, 2025 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs maintenance on JSON schema files by regenerating them and removing an obsolete schema file (theme-props.schema.json) that is no longer used due to theme-related changes in the codebase.

Key Changes:

  • Removed the obsolete theme-props.schema.json file
  • Added missing required fields to various schema definitions for better validation
  • Reordered enum values alphabetically in multiple schemas

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
theme-props.schema.json Removed obsolete schema file for theme properties
theme-changes.schema.json Added required fields and reordered enum values alphabetically
selector.schema.json Reordered ElementType enum values alphabetically
index.ts Updated schema generation command comment
imports.schema.json Restructured to add definitions wrapper and required fields
class.schema.json Updated JSON schema version from draft-06 to draft-07
binding.schema.json Reordered ElementType enum values alphabetically

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev changed the base branch from 20.1.x to master November 25, 2025 12:20
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Nov 25, 2025
@Lipata Lipata merged commit 18587fd into master Nov 25, 2025
7 of 11 checks passed
@Lipata Lipata deleted the dpetev/migrations-schema-upkeep branch November 25, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants